[PATCH input-synaptics 0/5] Fix a number of module configuration regressions

Gaetan Nadon memsize at videotron.ca
Tue Jun 14 04:47:30 PDT 2011


On Tue, 2011-06-14 at 13:51 +1000, Peter Hutterer wrote:

> On Mon, Jun 13, 2011 at 07:43:26PM -0400, Gaetan Nadon wrote:
> > Aside from one packaging error, mostly adding confusion and causing extra work.
> 
> tbh, I'd rather prefer reverting the changes and then implementing your
> changes on top. In your patch 4/5 we'd restore the behaviour to before
> 39afe69ad7d2 but it's not obvious in the history. A "Revert blah bla" is
> more visible. The other patches can then be pushed on top.
> 

I think that's the better approach as well. It would also highlight and
document
the desirable changes. 

> Would still like to hear back from Diego since he may have some extra
> arguments pro/con the whole thing. Right now, I'm quite willing to sacrifice
> build-time for maintainer time though.
> 

I would too. There is some guess work on my part due to changes not being
explained in the commit text. I am sure the bottom line will be on the plus side.

> Cheers,
>   Peter
> > 
> > Gaetan Nadon (5):
> >   Use appropriate Autoconf statements to check for prerequisites
> >   Do not install ChangeLog and README with documentation
> >   man: there is no need to create the "man" source directory
> >   man: restore the standard man pages makefile
> >   Regroup the distribution makefile rules together
> > 
> >  Makefile.am     |   42 ++++++++----------------------------------
> >  configure.ac    |    6 ++++--
> >  man/Makefile.am |   47 +++++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 59 insertions(+), 36 deletions(-)
> >  create mode 100644 man/Makefile.am
> > 
> > -- 
> > 1.7.4.1
> > 
> > _______________________________________________
> > xorg-devel at lists.x.org: X.Org development
> > Archives: http://lists.x.org/archives/xorg-devel
> > Info: http://lists.x.org/mailman/listinfo/xorg-devel
> > 


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110614/12a74b90/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110614/12a74b90/attachment.pgp>


More information about the xorg-devel mailing list