[PATCH input-synaptics 3/5] man: there is no need to create the "man" source directory

Dan Nicholson dbn.lists at gmail.com
Tue Jun 14 05:56:50 PDT 2011


On Tue, Jun 14, 2011 at 1:41 AM, Diego Elio Pettenò <flameeyes at gmail.com> wrote:
> Il giorno lun, 13/06/2011 alle 19.43 -0400, Gaetan Nadon ha scritto:
>>
>> This directory is created when the source code is extracted from git.
>> There are 175 other man pages directories in X.Org and none are
>> created from the makefile.
>
> You're assuming always running a build in-place. That might not be the
> case. Indeed Gentoo has been building Xorg modules out-of-tree for quite
> a while now.
>
> In a out-of-tree build, the directories are to be created: with a
> recursive Makefile, ./config.status would create them to convert
> Makefile.in to Makefile; on a non-recursive Makefile, it is the task of
> the target rule to create the directory. Interestingly enough, when
> using subdir-objects, the Makefile rules already include that for all
> the other targets.

I think what Gaetan may not be noticing is that you changed the
Makefile to be non-recursive. I think this is the only one in the xorg
world. If that's the way the maintainer wants it, then this patch
should be dropped. You need to create the target subdir manually,
although the PHONY mandir rule is unnecessary as far as I can tell.

--
Dan


More information about the xorg-devel mailing list