[PATCH 07/15] Replace the motion estimator
Daniel Stone
daniel at fooishbar.org
Tue Jun 14 09:00:56 PDT 2011
Hi,
On Fri, Jun 10, 2011 at 09:39:23PM +0200, Simon Thum wrote:
> On 06/09/2011 09:57 PM, Daniel Stone wrote:
> > +/*
> > + * Fit a line through the three most recent points in the motion
> > + * history and return relative co-ordinates.
> > + *
> > + * Three forms of filtering are present:
> > + * Acceleration - pointer accelerating too fast
> > + * Jerk - too great a change in pointer acceleration
> At this stage, perhaps it's better to talk about fingers or touch
> points. Pointer acceleration, I can assure, has no way of interfering here.
>
> It's all the more ambiguous since synaptics actually interacts with the
> server's pointer acceleration.
Good point (ha), thanks. I've changed all the comments to refer to
finger or finger position now.
> > @@ -2594,7 +2654,7 @@ HandleState(InputInfoPtr pInfo, struct SynapticsHwState *hw, CARD32 now,
> > priv->lastButtons = buttons;
> >
> > /* generate a history of the absolute positions */
> > - if (inside_active_area)
> > + if (inside_active_area && actual)
> > store_history(priv, hw->x, hw->y, hw->millis);
> I sounds good but seems to belong somewhere else.
Fair, I'll move these into another commit.
Cheers,
Daniel
More information about the xorg-devel
mailing list