[PATCH 01/15] Fix pressure->motion property format

Peter Hutterer peter.hutterer at who-t.net
Tue Jun 14 14:14:55 PDT 2011


On Tue, Jun 14, 2011 at 05:02:55PM +0100, Daniel Stone wrote:
> On Tue, Jun 14, 2011 at 02:11:42PM +1000, Peter Hutterer wrote:
> > On Thu, Jun 09, 2011 at 08:57:22PM +0100, Daniel Stone wrote:
> > > From: Derek Foreman <derek.foreman at collabora.co.uk>
> > > 
> > > UINT32, not float.
> > 
> > not that a negative value would make sense here but the driver (and your
> > code) uses int internally so a commit message fixup would be in order.
> > in this case we should also check for negative values. or you switch this
> > patch to use CARD32. 
> 
> Ah yep, I'll make it CARD32.

while you're at it, please change the "32 bit" in synaptics-properties.h to
CARD32 for this property so the documentation is in line with the code.

Cheers,
  Peter


More information about the xorg-devel mailing list