[PATCH 7/7] dix: Fix types in WindowOptRec
Daniel Stone
daniel at fooishbar.org
Fri Jun 17 13:02:25 PDT 2011
Hi,
On Fri, Jun 17, 2011 at 02:36:37PM -0400, Adam Jackson wrote:
> No reason for these to be 64 bits on LP64.
>
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
> include/windowstr.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/windowstr.h b/include/windowstr.h
> index 4a7a0f4..a066a2e 100644
> --- a/include/windowstr.h
> +++ b/include/windowstr.h
> @@ -87,8 +87,8 @@ typedef struct _WindowOpt {
> struct _OtherClients *otherClients; /* default: NULL */
> struct _GrabRec *passiveGrabs; /* default: NULL */
> PropertyPtr userProps; /* default: NULL */
> - unsigned long backingBitPlanes; /* default: ~0L */
> - unsigned long backingPixel; /* default: 0 */
> + unsigned backingBitPlanes; /* default: ~0L */
> + unsigned backingPixel; /* default: 0 */
> RegionPtr boundingShape; /* default: NULL */
> RegionPtr clipShape; /* default: NULL */
> RegionPtr inputShape; /* default: NULL */
Shouldn't these be CARD32?
That aside, I love the entire series, so:
Reviewed-by: Daniel Stone <daniel at fooishbar.org>
Cheers,
Daniel
More information about the xorg-devel
mailing list