[PATCH] dix: Fill in errorValue in ChangeGC for tile/stipple/clip BadMatch

Adam Jackson ajax at redhat.com
Mon Jun 20 10:11:43 PDT 2011


On 6/18/11 3:25 AM, Keith Packard wrote:
> On Fri, 17 Jun 2011 15:26:41 -0400, Adam Jackson<ajax at redhat.com>  wrote:
>
>> +		    if (client)
>> +			client->errorValue = pPixmap->drawable.id;
>>   		    error = BadMatch;
>
> Oddly enough, a Match error does not return the mis-matching value.

That's easily the worst thing I've heard about the core protocol in at 
least 24 hours.

- ajax



More information about the xorg-devel mailing list