[PATCH libX11 1/2] config: require fop minimum version 1.0

Dan Nicholson dbn.lists at gmail.com
Thu Jun 23 11:49:53 PDT 2011


On Thu, Jun 23, 2011 at 5:42 AM, Gaetan Nadon <memsize at videotron.ca> wrote:
> This version fixes a bug in fop 0.95 where fop crashes in the
> presence of some characters like the latin capital sharp s.
>
> The XORG_WITH_FOP macro must be at version 1.15 in order
> to be able to specify the minimum version.
>
> Note the parameter position change. Due to limited usage
> and requiring 1.15, it turns out to be backward compatible.
>
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> ---
>  configure.ac |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index c085df3..c91ae98 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -20,14 +20,14 @@ AM_MAINTAINER_MODE
>  # Initialize libtool
>  AC_PROG_LIBTOOL
>
> -# Require xorg-macros minimum of 1.12 for DocBook external references
> +# Require xorg-macros minimum of 1.15 for fop minimum version
>  m4_ifndef([XORG_MACROS_VERSION],
> -          [m4_fatal([must install xorg-macros 1.12 or later before running autoconf/autogen])])
> -XORG_MACROS_VERSION(1.12)
> +          [m4_fatal([must install xorg-macros 1.15 or later before running autoconf/autogen])])
> +XORG_MACROS_VERSION(1.15)
>  XORG_DEFAULT_OPTIONS
>  XORG_ENABLE_SPECS
>  XORG_WITH_XMLTO(0.0.22)
> -XORG_WITH_FOP([no])
> +XORG_WITH_FOP([1.0])

In addition to making 1.0 necessary, you've changed the default from
"no" to "auto" by omitting the second parameter. Please keep the "no"
or add a second commit explaining why "auto" should be used.

Thanks,
--
Dan


More information about the xorg-devel mailing list