[PATCH libX11 3/3] config: restore building pdf with fop by default

[Gaetan Nadon]

On Fri, 2011-06-24 at 17:11 -0700, Dan Nicholson wrote:

> On Fri, Jun 24, 2011 at 7:59 AM, Gaetan Nadon <memsize at videotron.ca> wrote:
> > All X.Org documentation in all four formats are build by default.
> > An expection was introduced by commit 1ec89689fc77 for libX11.
> >
> > All documentation can be individually disbaled using
> > --without-docs/specs/deve-docs.
> > The pdf/ps format can be disabled using --without-fop.
> >
> > There are sufficient mechanisms for an individual to optimize
> > the build speed, if that is the concern.
> >
> > On the other hand, having only one module turning off pdf requires
> > everyone who do need to build all docs in all formats to know and
> > remember this exception and configure using --with-fop.
> >
> > Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> 
> I'd prefer not. The people that know they need to build all the docs
> in all formats are also aware of the options and can pass --with-fop
> to all modules. That has the added advantage that configure would
> error if they didn't have the correct components instead of silently
> continuing. On the other hand, random builders who happen to have fop
> installed will have their build time massively increased for a benefit
> they probably don't want anyway. Honestly, unless you're building
> specifically to create documentation, why would you want pdfs of all
> the compose charts?
> 

I suspected as much. Why not making "no" the default for all modules. I
am always looking at the "consistent" side of things.
It's always harder to document in the release notes that "all modules
works this way, except this one..."

> 
> If people want this, no big deal, but can you at least post a
> difference building --with-fop and --without-fop? I have old fop on my
> system and it's failing to build.
> 

I have not done a lot of runs, but the compose table take 3-4 mins per
outpout format. The tables and the libX11 specs are the 2 biggest docs
of all.

That leaves us to choose between
XORG_WITH_FOP([1.0],[no]) I'd say it would be the distros call on this
one.
XORG_WITH_FOP([],[no])    the status quo

Thanks!


> --
> Dan


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110625/1484f321/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110625/1484f321/attachment-0001.pgp>