[PATCH] glx: Add _glapi_create_table_from_handle

[Jeremy Huddleston]

Those bits in the NoOp stub can be left out on Win32 (or you can tell me the Win32 way of figuring that out).  It's just used to provide extra info to give a hint as to which call was unimplemented.

This should remove that functionality from Win32.

diff --git a/glx/glapi_gentable.c b/glx/glapi_gentable.c
index a9ba3af..991c17a 100644
--- a/glx/glapi_gentable.c
+++ b/glx/glapi_gentable.c
@@ -31,7 +31,10 @@
 #include <dix-config.h>
 #endif
 
+#ifndef WIN32
 #include <execinfo.h>
+#endif
+
 #include <dlfcn.h>
 #include <stdlib.h>
 #include <stdio.h>
@@ -46,6 +49,8 @@
 static void
 __glapi_gentable_NoOp(void) {
     const char *fstr = "Unknown";
+
+#ifndef WIN32
     void *frames[2];
 
     if(backtrace(frames, 2) == 2) {
@@ -54,6 +59,7 @@ __glapi_gentable_NoOp(void) {
         if(info.dli_sname)
             fstr = info.dli_sname;
     }
+#endif
 
     LogMessage(X_ERROR, "GLX: Call to unimplemented API: %s\n", fstr);
 }



On Jun 27, 2011, at 7:05 AM, Jon TURNEY wrote:

> On 14/06/2011 21:34, Jeremy Huddleston wrote:
>> _glapi_create_table_from_handle was recently added to mesa to ease creation of
>> a _glapi_table.  This commit brings this API over to xserver for use in
>> XQuartz (next commit).
>> 
>> The API was generated with scripts from current mesa followed by various
>> script-foo to remove entries that are not in the server and add those which
>> are still in the server but not in mesa (CullParameterdvEXT and
>> CullParameterfvEXT)
>> 
>> Signed-off-by: Jeremy Huddleston<jeremyhu at apple.com>
>> 
>> Probably too big for the list, so see it here:
>> http://cgit.freedesktop.org/~jeremyhu/xserver/commit/?id=8bcb92245085e7c7ba81942381b4a75e90b8d355
> 
> This breaks the cygwin build [1], as neither the backtrace() nor dladdr() extensions are available.
> 
> Suggestions as to how to change this to make it more portable welcome :-)
> 
> [1] http://tinderbox.freedesktop.org/builds/2011-06-26-0003/logs/xserver/#build
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>