[PATCH RESEND synaptics 1/2] Revert "build: collapse all Makefile.am files into a single non-recursive one."

Daniel Stone daniel at fooishbar.org
Tue Jun 28 08:33:51 PDT 2011


On Tue, Jun 28, 2011 at 11:19:40AM -0400, Gaetan Nadon wrote:
> This reverts commit 39afe69ad7d2258d4043044d1283bd6e311e48da.
> 
> Conflicts:
> 
> 	.gitignore
> 	Makefile.am
> 
> This patch is to review "non-recursive make" commit 39afe69ad7.
> This will formalize the review being held on xorg-devel list.
> 
> http://lists.x.org/archives/xorg-devel/2011-June/023321.html
> http://lists.x.org/archives/xorg-devel/2011-June/023233.html
> 
> There are a couple of minor code changes unrelated to makefile recursiveness
> which can be resubmitted should the revert be accepted:
>   @DRIVER_NAME at _drv_ladir = @inputdir@ to
>     input_LTLIBRARIES = @DRIVER_NAME at _drv.la
>   noinst_PROGRAMS to check_PROGRAMS
> 
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>

For both patches:
Acked-by: Daniel Stone <daniel at fooishbar.org>

The changes seem to have broken ChangeLog generation too, such that:
make -C build; sudo make -C build install; make -C build
will cause a warning about overwriting ChangeLog due to permissions, as
it gets generated by both make all and make install.

Either way, I don't have an issue with the changes per se, but they
should definitely be coming through the list, and we should try to keep
the drivers as common as possible.

Cheers,
Daniel


More information about the xorg-devel mailing list