Resend: [PATCH xev] Show RandR events.

Aaron Plattner aplattner at nvidia.com
Thu Mar 3 13:54:23 PST 2011


On Thu, Mar 03, 2011 at 01:35:15PM -0800, Michael Thayer wrote:
> On Thu, 2011-03-03 at 11:37 -0800, Aaron Plattner wrote:
> > On Wed, Feb 16, 2011 at 04:00:25AM -0800, Michael Thayer wrote:
> > > +            if (rr_major >= 1 && rr_minor >= 2)
> > 
> > This check seems wrong, since it will include these event masks for RandR
> > version 2.2 but not 2.1 if we ever have a RandR 2.
> Fixed below.
> 
> Signed-off-by: Michael Thayer <michael.thayer at oracle.com>
> ---
> 
> I think the subject line says it all.  I was wanting to see what RandR events
> clients were getting and saw that this was on the X.Org todo list.
> 
>  configure.ac |    2 +-
>  xev.c        |  215 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 216 insertions(+), 1 deletions(-)

The updated change looks good to me.

Reviewed-by: Aaron Plattner <aplattner at nvidia.com>
Tested-by: Aaron Plattner <aplattner at nvidia.com>

Do you have a freedesktop.org
account, or would you like me to submit this for you?

-- Aaron


More information about the xorg-devel mailing list