[PATCH:libXt] Bug 34715: XtAppMainLoop doesn't work without a Display
Alan Coopersmith
alan.coopersmith at oracle.com
Mon Mar 7 13:19:37 PST 2011
On 03/ 7/11 03:00 AM, walter harms wrote:
>
>
> Am 06.03.2011 21:53, schrieb Alan Coopersmith:
>> From: Jordan Hayes <jordan at bitway.com>
>>
>> https://bugs.freedesktop.org/show_bug.cgi?id=34715
>>
>> XtAppNextEvent() doesn't return until there's an actual XEvent to be
>> handled; it handles Xt-internal events (inputs, timers, signals)
>> itself, but doesn't return (because of course, those aren't XEvents).
>> Which means that the exit flag doesn't get a chance to break the loop
>> until/unless there's an actual XEvent.
>>
>> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
>
> looks ok to me
>
> Signed-off-by: Walter Harms <whamrsm at bfs.de>
Do you mean Reviewed-by ?
http://www.x.org/wiki/Development/Documentation/SubmittingPatches#Signingoffandreviewing
I added signed-off-by as the committer doing the integration (and I did
change one more line than jordan - deleting the now unused event variable).
Ideally Jordan as original author would also reply with his Signed-off-by
as well.
--
-Alan Coopersmith- alan.coopersmith at oracle.com
Oracle Solaris Platform Engineering: X Window System
More information about the xorg-devel
mailing list