[PATCH 2/3] panoramiX: convert 0->panoramiXNumScreens loops to macro (v2)

[Daniel Stone]

Hi,

On Thu, Mar 10, 2011 at 09:23:34AM +1000, Dave Airlie wrote:
> diff --git a/Xext/saver.c b/Xext/saver.c
> index 1888603..492a54f 100644
> --- a/Xext/saver.c
> +++ b/Xext/saver.c
> @@ -1288,7 +1288,7 @@ ProcScreenSaverUnsetAttributes (ClientPtr client)
>         if (rc != Success)
>             return (rc == BadValue) ? BadDrawable : rc;
>  
> -       for(i = PanoramiXNumScreens - 1; i > 0; i--) {
> +       FOR_NSCREENS_BACKWARD(i) {
>              stuff->drawable = draw->info[i].id;
>              ScreenSaverUnsetAttributes(client);
>         }

You're changing semantics here by changing info[0..n], rather than
info[1..n].  Looks like you might just be able to turn this into a
FOR_NSCREENS_FORWARD_SKIP though?

Other than that, for the series:
Reviewed-by: Daniel Stone <daniel at fooishbar.org>

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110309/28b3d8c4/attachment.pgp>