[PATCH util-macros 2/3] XORG_WITH_GLIB: check for the GLib package

Peter Hutterer peter.hutterer at who-t.net
Thu Mar 10 17:13:54 PST 2011


On Thu, Mar 10, 2011 at 06:02:22PM -0500, Gaetan Nadon wrote:
> On Thu, 2011-03-10 at 09:04 -0800, Dan Nicholson wrote:
> 
> > This should probably say "for tests" or something so that builders
> > don't think they're gaining some extra functionality with glib.
> > 
> 
> So the odds of using GLib for purposes other than unit testing are
> pretty slim then.

mind you, even glib for the unit testing suite isn't actually that
necessary. The only features we really use is g_assert, so arguably we could
easily not use glib and just call the functions directly.

Cheers,
  Peter

> I wrote the macro such that it can be used standalone, dev tools
> perhaps.
> 
> All your changes are in. Thanks for the review!
> 
> Might as well share this matrix if it can help:
> 
>         --enable-unit-  --with  glib-2.0  glib-2.0  HAVE_GLIB
>         tests           -glib  probed    found               
>          -----------------------------------------------------------------------------
>         auto            auto    yes      yes       yes
>         auto            auto    yes      no        no
>         auto            yes     yes      yes       yes
>         auto            yes     yes      no        no	Error
>         auto            no      no       no        no
>         yes             auto    yes      yes       yes
>         yes             auto    yes      no        no   Error
>         yes             yes     yes      yes       yes
>         yes             yes     yes      no        no	Error
>         yes             no      no       no        no
>         no              auto    no       no        no
>         no              yes     no       no        no	Error
>         no              no      no       no        no
> 



More information about the xorg-devel mailing list