[PATCH libpciaccess] linux_sysfs: use rom_size = 0x1000 for VGA devices

Michael macallan at netbsd.org
Tue Mar 22 09:31:07 PDT 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Mar 22, 2011, at 11:59 AM, Alex Deucher wrote:

> On Tue, Mar 22, 2011 at 11:49 AM, Forest Bond
> <forest at alittletooquiet.net> wrote:
>> Hi,
>>
>> On Tue, Mar 22, 2011 at 11:15:27AM -0400, Adam Jackson wrote:
>>> On Tue, 2011-03-22 at 10:31 -0400, Forest Bond wrote:
>>>> This patch brings the linux_sysfs backend in parity with other  
>>>> backends,
>>>> which assume that VGA devices have fixed rom_size of 0x1000.  On my
>>>> machines, the previous behavior invariably gives rom_size = 0.
>>>
>>> So cards with ROMs bigger than 64k just get silently truncated?  No
>>> thanks.
>>
>> BTW, if this is wrong then I believe that pci_device_freebsd_probe  
>> and
>> pci_device_x86_probe are currently broken.  Maybe you can correct me.
>
> There are definitely roms > 64k.  Most newer radeons fall into this  
> category.

Also, Apple and Sun (open)firmware on graphics cards tends to be  
bigger than 64kB. Most of the time the only reason why you couldn't  
just take a PC radeon and flash it with Apple firmware was the ROM size.
Not that Xorg actually knows what to do with these ROMs but still,  
assuming it's 64kB is just plain wrong.

have fun
Michael

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iQEVAwUBTYjOy8pnzkX8Yg2nAQIK+ggAifjbTDwWLIeAN43J1Dgj2PAX/LDiMfhA
P5TiGnwTRGv047uksmqqcUexB+FvOzRR0OK0w1sY7Z4jJxmNx/FjwSNZdoI/tG5X
VFQq1rDKy4yJxWJOeSt6C4DfA8q1A9mLnpFhf93alPTyemR/fI2fDPvgn9LGZVwo
aw6eYmRQOh9zKHoHnbXKFYBtr0gGi6r9/67SIxA0kTipOIkdwCDr8KujfJMfgbp/
2Ga1QxUGX2FkqUgmUWMEaU2FmlxD/ewMd/FtYCtGV6wPNcM7E5hvUxfK9jpR//5E
TqkcwdyGjC8rNV+8+8IPRVMg1V8shdQJlmdH4FyeMelPes5EQKb+NQ==
=VP06
-----END PGP SIGNATURE-----


More information about the xorg-devel mailing list