[PATCH libpciaccess] linux_sysfs: use rom_size = 0x1000 for VGA devices

[Forest Bond]

Hi Adam,

On Wed, Mar 23, 2011 at 12:04:58PM -0400, Adam Jackson wrote:
> On 3/22/11 11:24 AM, Forest Bond wrote:
> >Hi,
> >
> >On Tue, Mar 22, 2011 at 11:15:27AM -0400, Adam Jackson wrote:
> >>On Tue, 2011-03-22 at 10:31 -0400, Forest Bond wrote:
> >>>This patch brings the linux_sysfs backend in parity with other backends,
> >>>which assume that VGA devices have fixed rom_size of 0x1000.  On my
> >>>machines, the previous behavior invariably gives rom_size = 0.
> >>
> >>So cards with ROMs bigger than 64k just get silently truncated?  No
> >>thanks.
> >
> >Sorry, the details are beyond me.  Is this better (untested)?
> 
> Better, but I still feel like you've got something else weird going
> on.

Okay.  FYI, I'm seeing this on multiple machines, and I've seen a few
pci_device_probe callers that handle rom_size == 0 as a special case and assume
0x1000.  Maybe there's a kernel problem here.

> What does the resource file for your VGA device contain anyway?
> 
> # cat /sys/bus/pci/devices/FOO/resource
> 
> ... where FOO is the domain:bus:device.function for your VGA device.

0x00000000fe400000 0x00000000fe7fffff 0x0000000000120204
0x0000000000000000 0x0000000000000000 0x0000000000000000
0x00000000d0000000 0x00000000dfffffff 0x000000000012120c
0x0000000000000000 0x0000000000000000 0x0000000000000000
0x000000000000f220 0x000000000000f227 0x0000000000020101
0x0000000000000000 0x0000000000000000 0x0000000000000000
0x0000000000000000 0x0000000000000000 0x0000000000000002
0x0000000000000000 0x0000000000000000 0x0000000000000000
0x0000000000000000 0x0000000000000000 0x0000000000000000
0x0000000000000000 0x0000000000000000 0x0000000000000000
0x0000000000000000 0x0000000000000000 0x0000000000000000
0x0000000000000000 0x0000000000000000 0x0000000000000000
0x0000000000000000 0x0000000000000000 0x0000000000000000

Thanks,
Forest
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110323/284d7369/attachment.pgp>