[PATCH xserver] dri2: Invalidate DRI2 buffers for all windows with the same pixmap on swap.

Michel Dänzer michel at daenzer.net
Fri Mar 25 07:52:43 PDT 2011


On Fre, 2011-03-25 at 15:45 +0100, Mario Kleiner wrote: 
> On Mar 25, 2011, at 3:32 PM, Michel Dänzer wrote:
> 
> > On Fre, 2011-03-25 at 14:47 +0200, Ville Syrjälä wrote:
> >> On Fri, Mar 25, 2011 at 12:35:37PM +0100, ext Michel Dänzer wrote:
> >>> From: Michel Dänzer <daenzer at vmware.com>
> >>>
> >>> Without this, when a compositing manager unredirects a fullscreen  
> >>> window which
> >>> uses DRI2 and page flipping, the DRI2 buffer information for the  
> >>> compositing
> >>> manager's output window (typically the Composite Overlay Window  
> >>> or root window)
> >>> may become stale, resulting in all kinds of hilarity.
> >>
> >> Make sense to me.
> >
> > Thanks, does that mean I have your Reviewed-by: ?
> 
> 
> fwiw (haven't touched that part of the code for multiple months), you  
> can also have a ...
> 
> Reviewed-by: Mario Kleiner <mario.kleiner at tuebingen.mpg.de>
> Acked-by: Mario Kleiner <mario.kleiner at tuebingen.mpg.de>
> 
> ... from me. I was suffering the same problems and was just about to  
> spend my weekend on hunting this bug in the xserver, so thanks for  
> saving my weekend!

No worries :), and thanks for the review.


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer


More information about the xorg-devel mailing list