[PATCH 01/10] os: use DebugF for debugging

Peter Hutterer peter.hutterer at who-t.net
Tue Mar 29 14:23:13 PDT 2011


On Tue, Mar 29, 2011 at 06:12:27PM +0300, Tiago Vignatti wrote:
> Signed-off-by: Tiago Vignatti <tiago.vignatti at nokia.com>

Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>

Cheers,
  Peter
> ---
>  os/utils.c |   18 ++++--------------
>  1 files changed, 4 insertions(+), 14 deletions(-)
> 
> diff --git a/os/utils.c b/os/utils.c
> index a365aca..f47177f 100644
> --- a/os/utils.c
> +++ b/os/utils.c
> @@ -1256,10 +1256,7 @@ System(char *command)
>        perror("signal");
>        return -1;
>      }
> -
> -#ifdef DEBUG
> -    ErrorF("System: `%s'\n", command);
> -#endif
> +    DebugF("System: `%s'\n", command);
>  
>      switch (pid = fork()) {
>      case -1:	/* error */
> @@ -1371,9 +1368,7 @@ Popen(char *command, char *type)
>      cur->next = pidlist;
>      pidlist = cur;
>  
> -#ifdef DEBUG
> -    ErrorF("Popen: `%s', fp = %p\n", command, iop);
> -#endif
> +    DebugF("Popen: `%s', fp = %p\n", command, iop);
>  
>      return iop;
>  }
> @@ -1448,9 +1443,7 @@ Fopen(char *file, char *type)
>      cur->next = pidlist;
>      pidlist = cur;
>  
> -#ifdef DEBUG
> -    ErrorF("Fopen(%s), fp = %p\n", file, iop);
> -#endif
> +    DebugF("Fopen(%s), fp = %p\n", file, iop);
>  
>      return iop;
>  #else
> @@ -1479,10 +1472,7 @@ Pclose(pointer iop)
>      int pstat;
>      int pid;
>  
> -#ifdef DEBUG
> -    ErrorF("Pclose: fp = %p\n", iop);
> -#endif
> -
> +    DebugF("Pclose: fp = %p\n", iop);
>      fclose(iop);
>  
>      for (last = NULL, cur = pidlist; cur; last = cur, cur = cur->next)
> -- 
> 1.7.0.4
> 



More information about the xorg-devel mailing list