[PATCH] fb: Fix memcpy abuse

Adam Jackson ajax at redhat.com
Mon May 2 07:37:45 PDT 2011


On 4/30/11 8:39 AM, Soeren Sandmann wrote:

> If I remember correctly, the main objection I had to the overlapped blt
> patch was that it inlined the C fallback into all the SIMD versions
> instead of just calling down through the delegate.
>
> Other than that, I agree that doing this in pixman would be best. In
> fact, I think it would make sense to have a full CopyArea implementation
> in pixman that would also handle rasterops and planemasks etc, but
> simply supporting overlapping in pixman_blt() is useful too.

I like the idea of having more in pixman and less in fb.  I kind of 
question whether you want to do the full CopyArea logic including 
computing exposures in pixman; I tend to lean towards just something 
enough to conform to miCopyProc.

- ajax


More information about the xorg-devel mailing list