Jeremy Huddleston jeremyhu at apple.com
Mon May 2 15:38:34 PDT 2011

Sure, a second logical commit sounds good.

Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

On May 2, 2011, at 15:36, Alan Coopersmith wrote:

> On 05/ 2/11 12:19 AM, Jeremy Huddleston wrote:
>> Hey Alan,
>> I think you missed my comment about adding -Werror=attributes for the $GCC case.  Could you please add that as well (gcc doesn't default to -Werror=attributes with -Werror).
> I thought that was only needed in the xorg-tls.m4, but I guess it makes sense
> as part of the general case.   That seems like a separate logical commit though,
> not part of exporting the STRICT_CFLAGS.
> -- 
> 	-Alan Coopersmith-        alan.coopersmith at oracle.com
> 	 Oracle Solaris Platform Engineering: X Window System

More information about the xorg-devel mailing list