[PATCH libXi] Allocate enough memory for raw events + extra data.
jamey at minilop.net
Tue May 3 08:31:56 PDT 2011
On Mon, May 02, 2011 at 11:29:49PM -0700, Jeremy Huddleston wrote:
> On May 2, 2011, at 11:24 PM, Peter Hutterer wrote:
> > On Mon, May 02, 2011 at 11:11:26PM -0700, Jeremy Huddleston wrote:
> >> I dislike macros. Why don't we make all those inline functions
> >> instead? That is so much cleaner.
> > if you want to touch Xlib macros, be my guest ;)
> I think I'll pick off lower hanging fruit first. Maybe someone else
> (GSOC ??) might want to clean up all that API.
Oh my god. If I could have changed the behavior of those macros then
porting Xlib to XCB would have been *so* much easier.
You might be able to get away with converting the macros to functions,
but the actual implementation of the macros is part of Xlib's ABI, so
practically unchangeable. (They get compiled into all the extension
libraries, including closed-source ones. For all I know there's some
health- or safety-critical app somewhere that they lost the source to
that's relying on Xlib internals.)
You might notice that XCB doesn't expose any function-like macros. :-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the xorg-devel