[PATCH] find_mode: Search for the mode closes to the specified rate

Jeremy Huddleston jeremyhu at apple.com
Mon May 9 09:21:29 PDT 2011


This was the intention of d9aeb4a7544ad4a33f6f54bc46bff5cdf231a986, but
find_mode was still picking the first string match rather than the
match with the closest refresh rate.

xrandr.c:740:3: warning: Value stored to 'bestDist' is never read
                bestDist = dist;
                ^          ~~~~

Found-by: clang static analyzer
Signed-off-by: Jeremy Huddleston <jeremyhu at apple.com>
---
 xrandr.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/xrandr.c b/xrandr.c
index 564d4da..10d034d 100644
--- a/xrandr.c
+++ b/xrandr.c
@@ -740,7 +740,6 @@ find_mode (name_t *name, double refresh)
 		bestDist = dist;
 		best = mode;
 	    }
-	    break;
 	}
     }
     return best;
-- 
1.7.4.4




More information about the xorg-devel mailing list