[PATCH 00/11] Misc input cleanup patches

Jamey Sharp jamey at minilop.net
Wed May 11 14:54:03 PDT 2011

On Wed, May 11, 2011 at 02:49:39PM +1000, Peter Hutterer wrote:
> Nothing overly exciting here, just the usual cleanups of mainly splitting
> functions into more bite-sized pieces. There are no (well, shouldn't be)
> real functionality changes, just making everything a tad more readable.

I've given more specific comments on several patches, but you can add my
reviewed-by to these patches with or without any changes I suggested:

[PATCH 01/11] dix: split out window owner event delivery from DeliverEventsToWindow
[PATCH 05/11] dix: move the grab activation condition into a if block.
[PATCH 06/11] dix: return deliveries from DeliverGrabbedEvent
[PATCH 07/11] Xi: split DeviceStateNotify delivery into a separate function
[PATCH 08/11] dix: use a tmp variable instead of multiple rClient(other).
[PATCH 09/11] include: add version_compare helper function
[PATCH 10/11] dix: replace CORE_EVENT and XI2_EVENT macros with inline functions.
[PATCH 11/11] dix: add is_xi2_event_of_type helper function.

I'm NAK-ing these:

[PATCH 02/11] dix: split out client delivery from DeliverEventsToWindow
[PATCH 03/11] dix: simplify button press check for passive grabs
[PATCH 04/11] dix: split implicit grab activation into a separate function.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110511/888a8350/attachment.pgp>

More information about the xorg-devel mailing list