[PATCH] test: only test for double alignment on 64 bit. (#36986)
alan.coopersmith at oracle.com
Thu May 19 12:14:24 PDT 2011
On 05/19/11 12:58 AM, Keith Packard wrote:
> On Thu, 19 May 2011 14:54:28 +1000, Peter Hutterer <peter.hutterer at who-t.net> wrote:
>> because I naïvely thought that we needed double alignment on 32 bit too and
>> the test was written that way. Oh well, how about this patch instead then.
>> it just disables the alignment check on 32 bit.
> Seems sensible to me.
>> +#ifdef _LP64
> Do you have any idea what the difference between _LP64, _XSERVER64 and
> __LP64__ are? And whether we should be using any of these here (or
> elsewhere in the server)?
_LP64 is commonly defined by the platforms/compilers.
_XSERVER64 was our own invention before that became a defacto standard,
there used to be a monster if (__IA64__) || (__sparcv9__) || ... (every
other 64-bit RISC CPU) to decide if it should be #defined.
Now we have in include/xorg-server.h:
#define _XSERVER64 1
-Alan Coopersmith- alan.coopersmith at oracle.com
Oracle Solaris Platform Engineering: X Window System
More information about the xorg-devel