Coping with -Wunused-but-set-variable, first round

[Jeremy Huddleston]

I would include the warning message as well.  gcc might not provide the best warning, so if you're feeling so inclined, you can check if there is a corresponding report in the clang static analysis reports:

http://people.freedesktop.org/~jeremyhu/analyzer

or just check the build log directly on tinderbox:

http://tinderbox.x.org



On May 20, 2011, at 08:37, Cyril Brulebois wrote:

> Cyril Brulebois <kibi at debian.org> (20/05/2011):
>> We have a lot of hits, but with the upcoming patchset (30 patches…) we
>> go down from 126 to 91; remaining parts include fb*, shrotpack*.h,
>> render2swap.c stuff, which I was a bit reluctant to patch without
>> thinking of it a bit. So the patchset should only have “easy to
>> ACK/NACK” items.
>> 
>> It's also available in my repository:
>>  git://anongit.freedesktop.org/~kibi/xserver unused-but-set-variable
> 
> And I forgot to ask this question: should I include some boilerplate
> in each commit message? (Including the actual warning message wouldn't
> bring much AFAICT, and would mean more work.)
> 
> If so, what? Just “Detected by -Wunused-but-set-variable, introduced
> in gcc 4.6” or something similar?
> 
> Mraw,
> KiBi.
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel