[PATCH xfree86] Signed-off-by: Oleh Nykyforchyn <oleh.nyk at gmail.com>

Dan Nicholson dbn.lists at gmail.com
Fri May 20 16:30:20 PDT 2011

On Mon, May 16, 2011 at 11:14 PM, Peter Hutterer
<peter.hutterer at who-t.net> wrote:
> On Mon, May 16, 2011 at 09:15:51PM +0300, Oleh R. Nykyforchyn wrote:
>> xfree86: allow negative conditions in "Match*" statements
>> Match statement syntax is extended to allow strings like:
>> "aaa,!a,bbb,!b,ccc,!c"
>> Match succeedes if an attribute matches aaa, bbb, or ccc, or
>> does not match neither a, b, or c.
>> Signed-off-by: Oleh Nykyforchyn <oleh.nyk at gmail.com>
> this needs an entry in the man page. I also wonder how long it will take us
> until we need full regex support...

We had this conversation before. I had a patch where you specified an
optional third argument stating what type of match you wanted. It was
then a trivial patch to add a regex match type. You weren't a huge
fan, though. :)


I was reworking it so that it accepted programmer names like "strcmp"
in addition to "string", but life has gotten in the way quite a bit. I
still think that would be a useful addition.

These changes that Oleh is proposing seem good to me at a glance. You
already merged them, but here's a belated:

Acked-by: Dan Nicholson <dbn.lists at gmail.com>


More information about the xorg-devel mailing list