[PATCH 0/4] Commonalize -novtswitch & -sharevts across platforms

Alan Coopersmith alan.coopersmith at oracle.com
Fri May 20 22:47:06 PDT 2011

Only built or tested on Solaris, even though it changes bsd & linux
platform specific code, so BSD & Linux folks should review/test.

This doesn't include the BSD support that Kibi started on, but should
hopefully make it easier to drop that in.

I did note that hw/xfree86/os-support/shared/VTsw_usl.c is no longer
actually shared by multiple platforms.   I waffled between whether it
made more sense to rename it to .../os-support/linux/lnx_VTsw.c or
to find some way to make BSD share it, since bsd_VTsw.c is almost 
identical except for the runtime checks to see if the right console
code is being used to allow VT.  I chose to punt and leave it for someone
else to play with later.

I also tried to see if we could move the handling of these options
completely into the common layer, but they're a bit too intertwined
with the platform-specific console code to make that easily doable.

I corrected the usage description to match what the code actually does,
not what the usage message claimed it did.   If the code is wrong, and
not switching on startup either is desired, then we've got a bug to fix.

Alan Coopersmith (4):
  xfree86: move -novtswitch & -sharevts argument handling up to common
  Xorg.man: Add -novtswitch and -sharevts options
  sun_init.c: Move vt switches to a switch_to helper function like
  sun_init.c: Implement novtswitch & sharevts for Solaris

 hw/xfree86/common/xf86Globals.c          |    2 +
 hw/xfree86/common/xf86Init.c             |   12 ++++++++
 hw/xfree86/common/xf86Privstr.h          |    2 +
 hw/xfree86/man/Xorg.man                  |    7 +++++
 hw/xfree86/os-support/bsd/bsd_init.c     |   17 ++++--------
 hw/xfree86/os-support/linux/lnx_init.c   |   25 ++++-------------
 hw/xfree86/os-support/solaris/sun_init.c |   42 +++++++++++++++++++++--------
 7 files changed, 65 insertions(+), 42 deletions(-)


More information about the xorg-devel mailing list