[PATCH] input: deliver raw events unconditionally for XI 2.1 clients.

Daniel Stone daniel at fooishbar.org
Sat May 21 05:21:28 PDT 2011


Hi,

On Wed, May 11, 2011 at 02:59:35PM +1000, Peter Hutterer wrote:
> @@ -2039,7 +2085,8 @@ DeliverEventToClients(DeviceIntPtr dev, WindowPtr win, xEvent *events,
>          mask = GetEventMask(dev, events, other);
>  
>          if (XaceHook(XACE_RECEIVE_ACCESS, client, win,
> -                    events, count))
> +                    events, count) ||
> +            FilterRawEvents(dev, events, grab, client))
>              /* do nothing */;
>          else if ( (attempt = TryClientEvents(client, dev,
>                          events, count,

I'd rather do the filtering in TryClientEvents, where we already do
pretty much all the filtering.

Speaking of: TryClientEvents will bin the event
if (grab && !SameClient(grab, client)).  So don't you need to change
that to get this working as well?

Otherwise:
Reviewed-by: Daniel Stone <daniel at fooishbar.org>

Cheers,
Daniel


More information about the xorg-devel mailing list