[PATCH] evdev: handle touchscreens without BTN_TOUCH

Peter Korsgaard jacmet at sunsite.dk
Mon May 23 23:47:58 PDT 2011

>>>>> "Peter" == Peter Hutterer <peter.hutterer at who-t.net> writes:


 >> With this change, the only thing differentiating between touchpads and
 >> touchscreens is the presence of BTN_TOOL_FINGER.

 Peter> Right, but if I read this correctly, you've removed a condition
 Peter> and now any device with absolute axes would get labeled as
 Peter> touchscreen, including keyboards with absolute axes.

 Peter> before the test was
 Peter>     if (pressure || touch)
 Peter>     {
 Peter>         if (lmr || finger) touchpad
 Peter>         else touchscreen
 Peter>     }

 Peter> whereas now you have 
 Peter>     if (pressure || touch || !(x/y relative))
 Peter>     {
 Peter>         if (finger) touchpad
 Peter>         else touchscreen
 Peter>     }

 Peter> so, any device that doesn't have relative x/y axes will fall into this
 Peter> branch. there are a few keyboards out there with axes (volume control,
 Peter> zoom), we probably shouldn't label them as touchscreens.

Yes, but all of this is in a has abs X/Y check. Keyboards presumably
don't have absolute X/Y axes?

Bye, Peter Korsgaard

More information about the xorg-devel mailing list