[PATCH evdev v2] Export product/vendor ID through a property.

Peter Korsgaard jacmet at sunsite.dk
Tue May 24 05:13:16 PDT 2011

>>>>> "Peter" == Peter Hutterer <peter.hutterer at who-t.net> writes:

 Peter> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
 Peter> Reviewed-by: Daniel Stone <daniel at fooishbar.org>
 Peter> ---
 Peter> Changes to v1:
 Peter> - EVIOCGID returns a struct input_id, use that instead of ushort[4];
 Peter>   no functional change, struct input_id is a struct of 4 ushorts anyway.

Looks good. Reminds me of the discussion we had in the past about
providing EVIOCGPHYS in a property (for multihead touchscreens).

 Peter> @@ -2340,12 +2370,14 @@ EvdevSetProperty(DeviceIntPtr dev, Atom atom, XIPropertyValuePtr val,
 Peter>      } else if (atom == prop_swap)
 Peter>      {
 Peter>          if (val->format != 8 || val->type != XA_INTEGER || val->size != 1)
 Peter> +
 Peter>              return BadMatch;

Why the extra empty line in the middle of the conditional?

Bye, Peter Korsgaard

More information about the xorg-devel mailing list