[PATCH 01/14] Xext: Get rid of useless checks.

[Jeremy Huddleston]

1,2:
   Ditto Alan's Response

3,4:
   Duplicates

5,6:
   Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

7,8,9:
   Disgusted-by: Jeremy Huddleston <jeremyhu at apple.com>
   Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

10:
   Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

11:
   I'd rather remove them than mark them unused

12:
   Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

13,14:
   Why not just remove the dead code or move the declaration into the #if 0?



On May 24, 2011, at 09:41, Cyril Brulebois wrote:

> As noted in a comment, that can't actually happen.
> 
> Those warnings go away accordingly:
> |   CC     xvmc.lo
> | xvmc.c: In function 'XvMCExtensionInit':
> | xvmc.c:671:21: warning: the comparison will always evaluate as 'false' for the address of 'XvMCScreenKeyRec' will never be NULL [-Waddress]
> | xvmc.c: In function 'XvMCFindXvImage':
> | xvmc.c:749:22: warning: the comparison will always evaluate as 'false' for the address of 'XvMCScreenKeyRec' will never be NULL [-Waddress]
> 
> Signed-off-by: Cyril Brulebois <kibi at debian.org>
> ---
> Xext/xvmc.c |    5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/Xext/xvmc.c b/Xext/xvmc.c
> index 4d29941..d49966f 100644
> --- a/Xext/xvmc.c
> +++ b/Xext/xvmc.c
> @@ -668,9 +668,6 @@ XvMCExtensionInit(void)
> {
>    ExtensionEntry *extEntry;
> 
> -   if(XvMCScreenKey == NULL) /* nobody supports it */
> -	return; 
> -
>    if(!(XvMCRTContext = CreateNewResourceType(XvMCDestroyContextRes,
> 					      "XvMCRTContext")))
> 	return;
> @@ -746,8 +743,6 @@ XvImagePtr XvMCFindXvImage(XvPortPtr pPort, CARD32 id)
>     XvMCAdaptorPtr adaptor = NULL;
>     int i;
> 
> -    if(XvMCScreenKey == NULL) return NULL;
> -
>     if(!(pScreenPriv = XVMC_GET_PRIVATE(pScreen))) 
>         return NULL;
> 
> -- 
> 1.7.5.1
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>