[PATCH:xts 03/16] xts5: Fix missing type specifier.

walter harms wharms at bfs.de
Thu May 26 02:55:14 PDT 2011



Am 25.05.2011 13:00, schrieb Cyril Brulebois:
> The caller stores the result in an integer, so let's use that as return
> type (which is the default anyway):
> |   CC     checkevent.lo
> | checkevent.c:664:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
> | check_ext_event(good,ev)
> | ^~~~~~~~~~~~~~~
> 
> Signed-off-by: Cyril Brulebois <kibi at debian.org>
> ---
>  xts5/src/lib/checkevent.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/xts5/src/lib/checkevent.c b/xts5/src/lib/checkevent.c
> index 3248ed8..40a0e60 100644
> --- a/xts5/src/lib/checkevent.c
> +++ b/xts5/src/lib/checkevent.c
> @@ -661,7 +661,7 @@ char	tempstr[50];
>  }
>  
>  #ifdef INPUTEXTENSION
> -check_ext_event(good,ev)
> +int check_ext_event(good,ev)
>  XEvent *good, *ev;
>  {
>  int i;


One point of ansi-c (~1980) was to move the arguments into the braces.
Is there a policy on that ? if not i suggest to use kr2ansi to fix these.

re,
 wh


More information about the xorg-devel mailing list