[PATCH xf86-input-synaptics] build: use dnl for configure.ac comments

Simon Thum simon.thum at gmx.de
Sun May 29 03:44:37 PDT 2011


On 05/26/2011 03:33 AM, Peter Hutterer wrote:
> On Wed, May 25, 2011 at 04:29:15PM +0200, Diego Elio Pettenò wrote:
>> Il giorno mer, 25/05/2011 alle 16.20 +0200, Cyril Brulebois ha scritto:
>>>
>>> just curious; do you have numbers? ./configure is usually insanely
>>> long, so I'm not sure a few dozens/hundreds lines are going to make
>>> any difference.
>>
>> Honestly? No it's unlikely to make any visible difference whatsoever.
>>
>> It's just a pet peeve of mine, because by not using dnl (in macros,
>> mostly) you _could_ significantly increase the size of the generated
>> file.
> 
> http://www.gnu.org/software/autoconf/manual/autoconf.html#Autoconf-Language
> You can include comments in configure.ac files by starting them with the
> ‘#’. For example, it is helpful to begin configure.ac files with a line like
> this:
> 
>      # Process this file with autoconf to produce a configure script.
> 
> 
> If there are no visible differences, I'd rather stick with what is
> recommended by the documentation, tbh.
Another point would be that perhaps it's easier to "debug" since the
comments may serve as markers in the output.

In loops, dnl should obviously be preferred, but here I don't see much
benefit.

Cheers,

Simon



More information about the xorg-devel mailing list