[PATCH util-macros 1/6] Fix the test for -Werror=attributes

Jeremy Huddleston jeremyhu at apple.com
Tue Nov 1 13:56:53 PDT 2011


Thanks for the catch.

I've also added -errwarn=E_NO_IMPLICIT_DECL_ALLOWED

Do you want to add corresponding SunCC flags for the other -Werror=?

On Nov 1, 2011, at 1:37 PM, Alan Coopersmith wrote:

> I only see one argument to AC_LANG_SOURCE in
> https://www.gnu.org/software/autoconf/manual/html_node/Generating-Sources.html
> 
> Did you mean to change the macro to AC_LANG_PROGRAM?
> 
> 	-alan-
> 
> On 11/01/11 13:16, Jeremy Huddleston wrote:
>> The current test was always failing to compile because 'return 0;' was
>> global rather than in the body of a function.
>> 
>> Signed-off-by: Jeremy Huddleston<jeremyhu at apple.com>
>> ---
>>  xorg-macros.m4.in |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in
>> index 0527dfe..3b02190 100644
>> --- a/xorg-macros.m4.in
>> +++ b/xorg-macros.m4.in
>> @@ -1431,7 +1431,7 @@ if test "x$GCC" = xyes ; then
>>      AC_MSG_CHECKING([if $CC supports -Werror=attributes])
>>      save_CFLAGS="$CFLAGS"
>>      CFLAGS="$CFLAGS $STRICT_CFLAGS -Werror=attributes"
>> -    AC_COMPILE_IFELSE([AC_LANG_SOURCE([return 0;])],
>> +    AC_COMPILE_IFELSE([AC_LANG_SOURCE([], [return 0;])],
>>  		      [STRICT_CFLAGS="$STRICT_CFLAGS -Werror=attributes"
>>  		       AC_MSG_RESULT([yes])],
>>  		      [AC_MSG_RESULT([no])])
> 
> 
> -- 
> 	-Alan Coopersmith-        alan.coopersmith at oracle.com
> 	 Oracle Solaris Platform Engineering: X Window System
> 



More information about the xorg-devel mailing list