[PATCH 06/11] Move DoShowOptions to xf86Configure.c, delete xf86ShowOpts.c

Alan Coopersmith alan.coopersmith at oracle.com
Fri Nov 4 07:47:29 PDT 2011


On 11/04/11 05:53, Daniel Stone wrote:
> Hi,
>
> On 4 November 2011 05:34, Alan Coopersmith<alan.coopersmith at oracle.com>  wrote:
>> Gets rid of duplicate static copy of optionTypeToString by putting
>> both callers of that helper function in the same source file.
>>
>> Signed-off-by: Alan Coopersmith<alan.coopersmith at oracle.com>
>
> I'd probably move the copyright statement from xf86ShowOpts.c as well,
> but with that fixed:
> Reviewed-by: Daniel Stone<daniel at fooishbar.org>

The copyright notice in xf86ShowOpts.c is identical to what's in
xf86Configure.c already - they didn't add a SuSE copyright notice,
just copied Alan Hourihane's for the code they were duplicating.

The only difference was the Author: line which I included in the
new comment before DoShowOptions.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list