[PATCH 00/11] Xserver string handling patches

Jeremy Huddleston jeremyhu at apple.com
Sun Nov 6 17:36:47 PST 2011


Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

On Nov 3, 2011, at 10:34 PM, Alan Coopersmith wrote:

> Some resends that didn't get reviewed yet, some reworked based on review
> comments so far, and some really new patches.
> 
> Alan Coopersmith (11):
>  Convert some malloc + strncpy pairs into strndup calls
>  AuthAudit: clean up string handling calls
>  LogVMessageVerb: Fix const mismatch warning
>  Convert glx/single2.c:DoGetString() to use asprintf()
>  Remove bad code from DoShowOptions (Xorg -showopts handler)
>  Move DoShowOptions to xf86Configure.c, delete xf86ShowOpts.c
>  Remove xf86FormatPciBusNumber from API, inline the one place its used
>  Convert a bunch of sprintf to snprintf calls
>  Reduce unnecessary string copying in xkbtext routines
>  Mark arguments to fopen/popen/system wrappers as const char *
>  Mark XKB char * as const to clean up gcc -Wwrite-strings warnings
> 
> dix/atom.c                             |    7 +-
> exa/exa_render.c                       |    6 +-
> glx/single2.c                          |    4 +-
> hw/dmx/examples/ev.c                   |    4 +-
> hw/dmx/glxProxy/glxscreens.c           |    5 +-
> hw/kdrive/ephyr/ephyrhostvideo.c       |    9 +-
> hw/kdrive/linux/linux.c                |    2 +-
> hw/kdrive/src/kinput.c                 |    4 +-
> hw/vfb/InitOutput.c                    |    3 +-
> hw/xfree86/common/Makefile.am          |    2 +-
> hw/xfree86/common/xf86.h               |    1 -
> hw/xfree86/common/xf86Configure.c      |   51 +++++++++
> hw/xfree86/common/xf86Option.c         |    6 +-
> hw/xfree86/common/xf86ShowOpts.c       |  130 -----------------------
> hw/xfree86/common/xf86pciBus.c         |   17 +--
> hw/xfree86/common/xf86sbusBus.c        |    2 +-
> hw/xfree86/fbdevhw/fbdevhw.c           |    6 +-
> hw/xfree86/os-support/bsd/bsd_init.c   |   10 +-
> hw/xfree86/os-support/bus/Sbus.c       |   12 +-
> hw/xfree86/os-support/linux/lnx_init.c |    2 +-
> hw/xfree86/x86emu/debug.c              |    2 +-
> include/os.h                           |    6 +-
> include/xkbfile.h                      |    4 +-
> include/xkbsrv.h                       |    4 +-
> os/connection.c                        |   15 ++--
> os/log.c                               |    2 +-
> os/osinit.c                            |    2 +-
> os/rpcauth.c                           |    7 +-
> os/utils.c                             |   14 +--
> os/xdmcp.c                             |    4 +-
> randr/rrinfo.c                         |    2 +-
> xkb/ddxList.c                          |    2 +-
> xkb/maprules.c                         |    2 +-
> xkb/xkbInit.c                          |    4 +-
> xkb/xkbfmisc.c                         |    2 +-
> xkb/xkbout.c                           |    6 +-
> xkb/xkbtext.c                          |  180 ++++++++++++++++----------------
> 37 files changed, 224 insertions(+), 317 deletions(-)
> delete mode 100644 hw/xfree86/common/xf86ShowOpts.c
> 
> -- 
> 1.7.3.2
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
> 



More information about the xorg-devel mailing list