[PATCH 05/12] Xi: add helper functions to alloc/free InputClientPtrs

Chase Douglas chase.douglas at canonical.com
Tue Nov 8 19:49:43 PST 2011


On 11/08/2011 07:08 PM, Peter Hutterer wrote:
> On Mon, Nov 07, 2011 at 06:01:32PM -0800, Chase Douglas wrote:
>> On 11/07/2011 01:39 PM, Peter Hutterer wrote:
>>> Currently not needed since the InputClientRec is a self-contained struct. As
>>> part of the touch rework that won't be the case in the future and a function
>>> to allocate/free memory appropriately is required.
>>>
>>> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
>>> ---
>>>  Xi/exevents.c |   23 ++++++++++++++++++-----
>>>  1 files changed, 18 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/Xi/exevents.c b/Xi/exevents.c
>>> index 53db036..7f8e6db 100644
>>> --- a/Xi/exevents.c
>>> +++ b/Xi/exevents.c
>>> @@ -1628,6 +1628,19 @@ SelectForWindow(DeviceIntPtr dev, WindowPtr pWin, ClientPtr client,
>>>      return Success;
>>>  }
>>>  
>>> +static void
>>> +FreeInputClient(InputClientsPtr *other)
>>> +{
>>> +    free((*other));
>>
>> I thought double parens has been taboo for quite some time now... why
>> did you use one here?
> 
> copy/paste error, amended locally. thanks.

Reviewed-by: Chase Douglas <chase.douglas at canonical.com>


More information about the xorg-devel mailing list