[PATCH:libICE 6/6] Remove ancient workaround for System V/386 Release 4.2 compiler bug

walter harms wharms at bfs.de
Thu Nov 10 08:48:42 PST 2011


I love this part, "UNIX System V/386 Release 4.2 Version 1"

Reviewed-by: walter <wharms at bfs.de>

Am 10.11.2011 07:19, schrieb Alan Coopersmith:
> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> ---
>  src/process.c |   12 +-----------
>  1 files changed, 1 insertions(+), 11 deletions(-)
> 
> diff --git a/src/process.c b/src/process.c
> index b566010..1e53ef9 100644
> --- a/src/process.c
> +++ b/src/process.c
> @@ -2279,17 +2279,7 @@ ProcessProtocolReply (
>  	    IcePoAuthProc authProc = myProtocol->auth_procs[(int)
>  		(iceConn->protosetup_to_you->my_auth_index)];
>  
> -#ifdef SVR4
> -
> -/*
> - * authProc is never NULL, but the cc compiler on UNIX System V/386
> - * Release 4.2 Version 1 screws up an optimization.  Unless there is
> - * some sort of reference to authProc before the function call, the
> - * function call will seg fault.
> - */
> -	    if (authProc)
> -#endif
> -		(*authProc) (iceConn,
> +	    (*authProc) (iceConn,
>  		&iceConn->protosetup_to_you->my_auth_state,
>  		True /* clean up */, False /* swap */,
>  	        0, NULL, NULL, NULL, NULL);


More information about the xorg-devel mailing list