[PATCH 1/2] Xext: don't swap CARD8 in SProcSELinuxQueryVersion

Jeremy Huddleston jeremyhu at apple.com
Thu Nov 10 23:14:43 PST 2011


Series:
Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

On Nov 8, 2011, at 9:34 PM, Peter Hutterer wrote:

> xselinux_ext.c: In function 'SELinuxSendItemsToClient':
> xselinux_ext.c:340:16: warning: unused variable 'n' [-Wunused-variable]
> xselinux_ext.c: In function 'SProcSELinuxQueryVersion':
> xselinux_ext.c:532:62: error: call to 'wrong_size' declared with attribute
> error: wrong sized variable passed to swap
> xselinux_ext.c:533:62: error: call to 'wrong_size' declared with attribute
> error: wrong sized variable passed to swap
> 
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
> Xext/xselinux_ext.c |    5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/Xext/xselinux_ext.c b/Xext/xselinux_ext.c
> index 56f2d1f..641368a 100644
> --- a/Xext/xselinux_ext.c
> +++ b/Xext/xselinux_ext.c
> @@ -526,11 +526,6 @@ ProcSELinuxDispatch(ClientPtr client)
> static int
> SProcSELinuxQueryVersion(ClientPtr client)
> {
> -    REQUEST(SELinuxQueryVersionReq);
> -
> -    REQUEST_SIZE_MATCH(SELinuxQueryVersionReq);
> -    swaps(&stuff->client_major);
> -    swaps(&stuff->client_minor);
>     return ProcSELinuxQueryVersion(client);
> }
> 
> -- 
> 1.7.7
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
> 



More information about the xorg-devel mailing list