[PULL v2] string handling, unit test & Solaris fixes

Alan Coopersmith alan.coopersmith at oracle.com
Mon Nov 21 10:40:38 PST 2011


On 11/20/11 13:01, Keith Packard wrote:
> On Tue, 08 Nov 2011 19:47:13 -0800, Alan Coopersmith<alan.coopersmith at oracle.com>  wrote:
>
>>         Add fallback implementation of strndup()
>
> The test code doesn't build on Linux. Here's a patch which seems to
> help -- you can't use the 'strndup' name with glibc; it's got magic for
> that these days...
>
> diff --git a/test/string.c b/test/string.c
> index 42a5e9c..e3a5adb 100644

Thanks, I'll squash that into my patch.

>
>>         Convert strncpy/strncat to strlcpy/strlcat
>
> This breaks the DMX build; I tried to fix this and failed...

I can build Xdmx fine here, but then I'm on an OS with the strl*
functions in libc.   I see that hw/dmx/config/xdmxconfig gets
built with the functions, but doesn't link against the fallback
code from os/strl*.c - I'll work on fixing that.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list