[PATCH] pkgconfig files should be installed to $(libdir)

[Gaetan Nadon]

On Wed, 2011-11-23 at 19:31 -0600, Yaakov (Cygwin/X) wrote:

> On Thu, 2011-11-17 at 07:43 -0800, Alan Coopersmith wrote:
> > Those are bugs then, they should all use $(datadir).
> > 
> > I know I've had to override some in the past when building distro
> > packages, but I thought we'd gotten all those fixes in to git by
> > now.
> 
> No, they must NOT go into $(datadir)/pkgconfig.  Here's why:
> 
> Presume that you install the *proto/xtrans headers/templates
> into /usr/include and the .pc files into /usr/share/pkgconfig, then
> proceed to use these headers to cross-compile another X.Org component
> with a sysroot-capable cross-toolchain, pkg-config will kindly add a
> -I/usr/include to your CFLAGS.  This will cause the native system
> headers to be picked up instead of the cross-target libc headers,
> causing all sorts of compile errors.
> 
> Furthermore, <X11/Xfuncproto.h> and <X11/Xpoll.h> (from xproto) and
> xtrans.pc have system-dependent substitutions, so they cannot be used
> for cross-compiling.
> 
> Therefore, regarding the original patch:
> 
> Reviewed-by: Yaakov Selkowitz <yselkowitz at users.sourceforge.net>
> 

I recall xtrans.pc was relocated from libdir to datadir a year or so ago
and mostly for cross-compilation reasons.

        Move xtrans.pc to /usr/share/pkg-config
        
        This fixes configuration in cross-compilation mode:
        pkg-config does not look for .pc in /usr/lib/pkg-config during
        cross-compilation to avoid picking up wrong libraries.
        
        Signed-off-by: Mikhail Gusarov <dottedmag at dottedmag.net>
        Acked-by: Julien Cristau <jcristau at debian.org>

 A double switch also occurred to util-macros which was a painful
exercise.

I feel obligated to Nack this path until the issue is resolved as it
will obviously break some systems. A library release may happen at any
time so it is important to think this through before committing a patch.

The patch should be reposted with the proper title [PATCH libxtrans] as
it was posted as an xserver patch and probably missed by many.


> 
> Yaakov
> Cygwin/X
> 
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20111124/574599da/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20111124/574599da/attachment.pgp>