[PATCH] x11proto: add permille, ezh, and EZH to keysymdef.h

Marko Myllynen myllynen at redhat.com
Wed Nov 30 00:42:36 PST 2011


Hi,

ping^3 - any comments about this? These patches got "Reviewed-by" over a
month ago but since then haven't heard any comments, positive or
negative, previous ping sent over two weeks ago..

Thanks,

On 2011-11-14 13:44, Marko Myllynen wrote:
> Hi,
> 
> On 2011-10-21 05:46, Matt Dew wrote:
>> On 10/20/2011 01:47 AM, Marko Myllynen wrote:
>>> On 2011-10-18 20:15, Matt Dew wrote:
>>>> On 10/17/2011 03:07 AM, Marko Myllynen wrote:
>>>>>
>>>>> I've now tested by building patched libX11 against the updated
>>>>> keysymdef.h and ezh/EZH/permille work in compose maps and keyboard map
>>>>> files as expected.
>>>>>
>>>>> I'm attaching an updated patch to update the comment section, a patch
>>>>> for the needed mapping in libX11, and, while at it, updating compose
>>>>> maps to use the ezh/EZH mnemonics.
>>>>
>>>> It's not my area of expertise so I probably won't catch anything but
>>>> glaring errors. But I didn't see any of those so:
>>>> Reviewed-by:  Matt Dew<marcoz at osource.org>
>>>>
>>>> Did you want to take a stab at updating the keysyms.xml?
>>>
>>> right, when I updated the documentation references I forgot to follow
>>> the documented procedure myself :)
>>>
>>> I'm attaching updated patches, the only change is the addition of the
>>> permille to keysyms.xml.
>>
>> Looks like there's quite a few missing from the XML file.  (Does anyone
>> know) Is the goal of the XML file to have all of the ones that are in
>> the .h file?
>>
>> Regardless,  looks good.
>> Reviewed-by:  Matt Dew<marcoz at osource.org>
> 
> pinging again after ~ three weeks of silence - the patch set should be
> complete, could it be applied to address #19687?
> 
> Thanks,
> 


-- 
Marko Myllynen


More information about the xorg-devel mailing list