[PATCH libXi] 1UL may be 4 bytes, force to 1ULL

Jamey Sharp jamey at minilop.net
Sun Oct 2 10:52:03 PDT 2011

On 10/2/11, Daniel Stone <daniel at fooishbar.org> wrote:
> On 2 October 2011 09:19, Jeremy Huddleston <jeremyhu at apple.com> wrote:
>> Peter, any thoughts on this?
> I think using * (1 << 16) * (1 << 16) is a better idea than (1ULL << 32).

And I think ldexp is a much better idea than either. :-) It's more
clear, and as an added bonus, probably faster. (You can multiply a
double by a power of two just by adding the exponents. Division by an
arbitrary constant is stupidly slow by comparison.)

To me, the interesting part of Jeremy's question was whether helper
functions are worthwhile for these conversions, and if so, where they
should live.


More information about the xorg-devel mailing list