[PULL] XI 2.1 - raw events and smooth scrolling

Daniel Stone daniel at fooishbar.org
Tue Oct 4 03:33:26 PDT 2011


On 3 October 2011 11:50, Max Schwarz <Max at x-quadraht.de> wrote:
>>       Input: Add smooth-scrolling support to GetPointerEvents
> There's a subtle bug on that one: Old-style scroll button presses create
> inverted emulated presses (and maybe inverted valuator events, but I don't
> know which direction is 'up' or 'down' on the valuator).

Good catch, thanks! Up is negative in the valuators, so this:

> Take a look at dix/getevents.c, GetPointerEvents():
>> switch(buttons) {
>> case 4:
>>    adj = 1.0;
>> [snip]
>> }

should be -1.0.  Care to send a patch with git-format-patch?


More information about the xorg-devel mailing list