libX11: Changes to 'master'
jeremyhu at apple.com
Mon Oct 10 16:06:40 PDT 2011
On Oct 10, 2011, at 15:31, Julien Cristau wrote:
> On Mon, Oct 10, 2011 at 14:13:57 -0700, Jeremy Huddleston wrote:
>> include/X11/Xlib.h | 1 +
>> 1 file changed, 1 insertion(+)
>> New commits:
>> commit f2651e03f3295a453a2965c3749bc8b6e66f1c09
>> Author: Jeremy Huddleston <jeremyhu at apple.com>
>> Date: Mon Oct 10 14:09:17 2011 -0700
>> Mark XKeycodeToKeysym as _X_DEPRECATED
>> Signed-off-by: Jeremy Huddleston <jeremyhu at apple.com>
> Is this a good idea? It's going to clutter people's build logs with
> warnings, when that function is never going away anyway. There's quite
> a lot of stuff using it.
Yes, and they should *not* be using it as it is deprecated. People that care about keeping their builds warning free will migrate to XGetKeyboardMapping, and people that don't care about warnings will ignore them.
_X_DEPRECATED exists for a reason. We should make sure that our API is properly annotated and not just mention these things in the man page. I'm sure there are plenty of other cases where things are not annotated right, but that doesn't mean we should leave them that way.
Letting people use XKeycodeToKeysym can lead to correctness bugs, so IMO, it's better to warn them instead:
More information about the xorg-devel