[PATCH] os: Print a newline when Error is called

Peter Hutterer peter.hutterer at who-t.net
Mon Oct 10 18:24:03 PDT 2011


On Mon, Oct 10, 2011 at 05:53:07PM -0700, Jeremy Huddleston wrote:
> 
> Signed-off-by: Jeremy Huddleston <jeremyhu at apple.com>
> ---
> 
>  os/log.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/os/log.c b/os/log.c
> index 2eddf06..0aa4429 100644
> --- a/os/log.c
> +++ b/os/log.c
> @@ -646,9 +646,9 @@ Error(const char *str)
>      const char *err = strerror(errno);
>  
>      if (str)
> -	LogWrite(-1, "%s: %s", str, err);
> +	LogWrite(-1, "%s: %s\n", str, err);
>      else
> -	LogWrite(-1, "%s", err);
> +	LogWrite(-1, "%s\n", err);
>  }
>  
>  void
> -- 
> 1.7.5.4

There are only very few callers. IMO we should replace them with 
    ErrorF("%s", strerror(errno)); 
and remove this one completely.

Cheers,
  Peter


More information about the xorg-devel mailing list