[PATCH xserver 1/7] Remove unused VT_SYSREQ_DEFAULT

Alan Coopersmith alan.coopersmith at oracle.com
Sat Oct 15 09:04:57 PDT 2011

For the series (1-7):
Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

Though 5 could use a little more explanation in the commit message, such
as a mention of how the return value is becoming void because no caller used
it and that the old msb_set static checked by each caller is replaced by
the p.hae static checked in sethae() when it's called.   (If you look at the
code carefully enough you can figure that out, as I did, but we greatly
appreciate commit messages that help people understand the code more quickly,
both during review now and years later when trying to track down changes.
http://who-t.blogspot.com/2009/12/on-commit-messages.html )

	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System

More information about the xorg-devel mailing list