[PATCH 1/2] xfree86: Fix type of IOPortBase to be a pointer
jeremyhu at apple.com
Sun Oct 16 13:50:30 PDT 2011
On Oct 16, 2011, at 9:32 AM, walter harms wrote:
>> @@ -487,8 +487,7 @@ int ScreenNum;
>> * actually mmap the start of the page, then the start of video
>> * I/O space is added as an internal offset.
>> - IOPortBase = (unsigned int)xf86MapInfoMap(memInfoP,
>> - (caddr_t)0x0, 0L)
>> + IOPortBase = (pointer)xf86MapInfoMap(memInfoP, (caddr_t)0x0, 0L)
>> - memInfoP->memInfo.u.map_info_mmap.internal_offset;
> I would expect a NULL instead of (caddr_t)0x0.
Yeah, well... that's what was there to begin with, and if I go down that road, I'll want to change 1000 other things in those files.
More information about the xorg-devel