[PATCH 1/2 v4] mieq: Provide better adaptability and diagnostics during mieq overflow

Keith Packard keithp at keithp.com
Sun Oct 16 22:15:29 PDT 2011

On Sun, 16 Oct 2011 21:56:43 -0700, Jeremy Huddleston <jeremyhu at apple.com> wrote:

> n_events_at_tail ? I'm not really sure what to call it.

If I had a good idea, I would have suggested it :-) Perhaps just don't
bother then, unless you have a sudden brain wave.

> It's not really any different.  I'm just doing an optimization
> there... Rather than just setting everything to 0 individually, just
> do one big memset.

See, it's a separate change from resizing the event queue.

> malloc isn't being called from within mieqEnqueue.  The resize is
> being done in mieqProcessInputEvents.

Right, that's what I expected and somehow mis-read the patch. And now I
understand why you were confused by my previous comment about
mieqGrowQueue only being called when the queue was full.

Sorry for the confusion, this looks good.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20111016/6e84b2e2/attachment.pgp>

More information about the xorg-devel mailing list