[PATCH 1/2 v5] mieq: Provide better adaptability and diagnostics during mieq overflow

Jeremy Huddleston jeremyhu at apple.com
Sun Oct 16 22:35:37 PDT 2011

On Oct 16, 2011, at 10:30 PM, Keith Packard wrote:

> On Sun, 16 Oct 2011 22:14:31 -0700, Jeremy Huddleston <jeremyhu at apple.com> wrote:
>> +    if ((miEventQueue.tail - miEventQueue.head) % miEventQueue.nevents >= (miEventQueue.nevents >> 1) &&
> I missed this use of '%'. And, this seems to be growing the queue
> whenever it's more than half full? Is that too pessimistic?

Re: %

Yeah, I missed that too when I was fixing the other one.  Will address.  I'm tired of spinning new versions of this patch and will wait for additional feedback before sending the final one.

Re: pessimism

I dunno.  They're your cats.  You tell me.  As much as I bang on the keyboard, I can't get the queue to resize larger than 32 with this scheme (starting at 2).

Maybe just resizing if all we have left is 2 * reserved space would be a good idea.


More information about the xorg-devel mailing list